Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-848] [Bug] BQ incremental materialization with _dbt_max_partition doesn't work for Preview in dbt Cloud with dbt show --inline #584

Open
2 tasks done
dbeatty10 opened this issue Aug 24, 2023 · 4 comments
Labels
cloud Issues related to dbt Cloud feature:incremental Issues related to incremental materializations feature:partitioning Issues related to table partitioning feature:show Issues related to dbt show command pkg:dbt-bigquery Issue affects dbt-bigquery type:bug Something isn't working as documented

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Aug 24, 2023

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

See this internal Slack thread for details:
https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1692582407653009

Expected Behavior

See internal Slack thread for details.

Steps To Reproduce

See above (and below).

{{
    config(
        materialized="incremental",
        incremental_strategy="insert_overwrite",
        partition_by={
            "field": "created_at_date",
            "data type: "DATE",
            "granularity": "day",
        })
}}

select * from {{ ref("incremental source date") }}
where created_at_date >= _dbt_max_partition

image

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response

@dbeatty10 dbeatty10 added type:bug Something isn't working as documented triage:product In Product's queue labels Aug 24, 2023
@github-actions github-actions bot changed the title [Bug] BQ incremental materialization with _dbt_max_partition doesn't work for Preview in dbt Cloud with dbt show --inline [ADAP-848] [Bug] BQ incremental materialization with _dbt_max_partition doesn't work for Preview in dbt Cloud with dbt show --inline Aug 24, 2023
@dbeatty10 dbeatty10 removed the triage:product In Product's queue label Aug 28, 2023
@dataders dataders added the feature:incremental Issues related to incremental materializations label Aug 31, 2023
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale Mark an issue or PR as stale, to be closed label Feb 28, 2024
@dbeatty10 dbeatty10 removed the Stale Mark an issue or PR as stale, to be closed label Feb 28, 2024
@stelios-c
Copy link

Hi, I keep coming across this, please keep it open, and if possible, fix!

@dbeatty10 dbeatty10 added feature:show Issues related to dbt show command cloud Issues related to dbt Cloud labels Apr 18, 2024
@colin-rogers-dbt
Copy link
Contributor

Likely related to #583

@carolinabtt
Copy link

I created a PR that could also solve this issue by updating the bigquery__get_empty_subquery_sql macro. dbt-labs/dbt-bigquery#1369

@amychen1776 amychen1776 added the feature:partitioning Issues related to table partitioning label Jan 6, 2025
@mikealfare mikealfare added the pkg:dbt-bigquery Issue affects dbt-bigquery label Jan 14, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-bigquery Jan 14, 2025
mikealfare pushed a commit that referenced this issue Jan 14, 2025
* first pass with contract check

* fix inheritence

* changelog

* fix test

* remove dbt-core pin
mikealfare pushed a commit that referenced this issue Jan 20, 2025
* first pass with contract check

* rename test class

* clean up test

* point to branch

* fix whitespace

* fix class name

* remove dbt-core pin
mikealfare pushed a commit that referenced this issue Jan 24, 2025
* update used gh actions ahead of set-output, node12 deprecation

* add changie log

* remove unneeded changelog

* Fix for changie that pointed to spark (#584)

---------

Co-authored-by: Neelesh Salian <[email protected]>
colin-rogers-dbt pushed a commit that referenced this issue Feb 3, 2025
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud Issues related to dbt Cloud feature:incremental Issues related to incremental materializations feature:partitioning Issues related to table partitioning feature:show Issues related to dbt show command pkg:dbt-bigquery Issue affects dbt-bigquery type:bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

7 participants