You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems to be redundant with defining a <adapter>__dateadd macro implementation, and I can't figure out why it's needed. (I'm working on a new dbt adapter and am trying to understand the purpose.)
I did a Github code search to try to find references to adapter.timestamp_add_sql and all I could find were implementations in nearly all adapters, and tests code that references it. Is testing the sole purpose? Can we consolidate and try to use the dbt.dateadd macro in testing instead of requiring adapters to define this method to generate SQL?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
It seems to be redundant with defining a
<adapter>__dateadd
macro implementation, and I can't figure out why it's needed. (I'm working on a new dbt adapter and am trying to understand the purpose.)I did a Github code search to try to find references to
adapter.timestamp_add_sql
and all I could find were implementations in nearly all adapters, andtests
code that references it. Is testing the sole purpose? Can we consolidate and try to use thedbt.dateadd
macro in testing instead of requiring adapters to define this method to generate SQL?Beta Was this translation helpful? Give feedback.
All reactions