Rename internal batch_info variable to previous_batch_results
#11056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMalcolm
added
Skip Changelog
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11056 +/- ##
==========================================
+ Coverage 89.15% 89.17% +0.02%
==========================================
Files 183 183
Lines 23764 23767 +3
==========================================
+ Hits 21186 21194 +8
+ Misses 2578 2573 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In 4050e37 we began excluding `previous_batch_results` from the serialized representation of the ModelNode. As such, we no longer need to check for it in `test_manifest.py`.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
…1056) * Rename `batch_info` to `previous_batch_results` * Exclude `previous_batch_results` from serialization of model node to avoid jinja context bloat * Drop `previous_batch_results` key from `test_manifest.py` unit tests In 4050e37 we began excluding `previous_batch_results` from the serialized representation of the ModelNode. As such, we no longer need to check for it in `test_manifest.py`. (cherry picked from commit 0f084e1)
QMalcolm
added a commit
that referenced
this pull request
Nov 27, 2024
…1056) (#11062) * Rename `batch_info` to `previous_batch_results` * Exclude `previous_batch_results` from serialization of model node to avoid jinja context bloat * Drop `previous_batch_results` key from `test_manifest.py` unit tests In 4050e37 we began excluding `previous_batch_results` from the serialized representation of the ModelNode. As such, we no longer need to check for it in `test_manifest.py`. (cherry picked from commit 0f084e1) Co-authored-by: Quigley Malcolm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Solution
We were using
batch_infoto store the information on previous batch execution (if available) at runtime. However this name is confusing. Thus, we're renaming it to something more applicable,previous_batch_results. This is a non-dangerous change becausebatch_infowasn't written out as part of any artifacts.Checklist