Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclude / tags for the creation of external tables #129

Closed
adrianbartnik opened this issue Jan 31, 2022 · 4 comments
Closed

Support exclude / tags for the creation of external tables #129

adrianbartnik opened this issue Jan 31, 2022 · 4 comments
Labels
enhancement New feature or request Stale

Comments

@adrianbartnik
Copy link

adrianbartnik commented Jan 31, 2022

Describe the feature

dbt supports selecting models by tags, e.g. dbt run --select tag:my_tag. We'd like to have a similar functionality for the dbt-external-tables package. The dbt source freshness command already supports this, see here, which is referenced by the README.md.

Describe alternatives you've considered

The alternative would be to list all tables manually using the select argument.

Additional context

We are using Snowflake, but this feature is applicate to all databases.

We are not sure how much complexity this would add the project and other input would be appreciated.

Who will this benefit?

This feature would allow more granular creation of external tables, e.g. in bigger projects if external tables need to be created in different databases by different technical users that create those tables. Using tags or exclude would simplify the code.

@adrianbartnik adrianbartnik added the enhancement New feature or request label Jan 31, 2022
@jtcohen6
Copy link
Collaborator

@adrianbartnik I totally hear you, and strongly agree! For better and for worse, this ends up being the same ask as the one in #109.

In order to support node selection, stage_external_sources would need to "graduate" from a macro (executed via run-operation) to an honest-to-goodness dbt task. As laid out in #109 (comment) (options 2+3), we could go one of two ways here:

  • Short term, medium difficulty: Migrate the logic from this package into dbt-core, and a built-in task (e.g. dbt source external)
  • Long term, high difficulty: Develop a pluggable task interface in dbt-core, which packages/users could tap into to define their own custom tasks that leverage the built-in capabilities of ManifestTask/GraphRunnableTask

@moseleyi
Copy link

moseleyi commented Jun 8, 2023

It would be great to be able to exclude certain tags. I use external tables from static CSV files (grographical data) that doesn't need to be refreshed until I need to do it manually.. This would be a great addition

Copy link

github-actions bot commented Dec 6, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 6, 2023
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants