make the list-agg columns conditionally tested #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
Link to Issue
DBX tests are failing in main because there is no support on Databricks for an
order_by
clause in thedbt.listagg
macro, so we can't guarantee the order of the array of values in models where we report a list of violations within a single record.Example:
You can see the values are reversed, but identical.
This PR makes those columns conditional in our test configuration so that they are tested for all other adapters except DBX.
Since CI is off, i am running these tests locally!
Integration Test Screenshot
Checklist