Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop letting code cleanup steps fail #72

Open
Tracked by #87
emmyoop opened this issue Mar 3, 2023 · 0 comments
Open
Tracked by #87

Stop letting code cleanup steps fail #72

emmyoop opened this issue Mar 3, 2023 · 0 comments
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Mar 3, 2023

These steps to remove blank lines/spaces show errors in the output even though we want to ignore the errors.

# this step will fail on whitespace errors but also correct them
- name: "Remove Trailing Whitespace Via Pre-commit"
continue-on-error: true
run: |
pre-commit run trailing-whitespace --files .bumpversion.cfg CHANGELOG.md .changes/*
git status
# this step will fail on newline errors but also correct them
- name: "Removing Extra Newlines Via Pre-commit"
continue-on-error: true
run: |
pre-commit run end-of-file-fixer --files .bumpversion.cfg CHANGELOG.md .changes/*
git status

Add || true logic to the commands to stop the errors from propagating to the output as they are not true errors. Also remove the continue-on-error lines as they will no longer be relevant.

@emmyoop emmyoop added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed oss_tooling labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

1 participant