Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest tag in GitHub releases #73

Open
Tracked by #87
emmyoop opened this issue Mar 3, 2023 · 0 comments · May be fixed by #85
Open
Tracked by #87

Fix latest tag in GitHub releases #73

emmyoop opened this issue Mar 3, 2023 · 0 comments · May be fixed by #85
Labels
bug Something isn't working

Comments

@emmyoop
Copy link
Member

emmyoop commented Mar 3, 2023

Right now, the "Latest" release is simply the chronologically latest release that is non-draft & non-prerelease. This means when we release a patch to an older version, it gets marked as lates in GitHub now.

Screen Shot 2023-03-03 at 9 46 11 AM

Example
first release 1.5.0 -> marked correctly as latest
now release 1.4.3 -> this is now incorrectly marked as latest

We need to determine if this is the true latest and mark it as such when releasing.

For now the workaround is to go in and update the releases appropriately in the UI when releasing a patch to an older version.

Details

You can list and filter releases with the gh cli: https://cli.github.com/manual/gh_release_list
If the current release is the same minor version or less with a higher patch, it should be marked latest.

Current Latest in GH Version Being Released Mark Version being released as latest
1.5.2 1.5.3 yes
1.5.2 1.4.8 no
1.5.2 1.6.0 yes
1.5.2 1.6.0b1 no

Never mark pre-releases or draft releases as latest

@emmyoop emmyoop added the bug Something isn't working label Mar 16, 2023
@emmyoop emmyoop linked a pull request Jul 25, 2023 that will close this issue
@emmyoop emmyoop added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed oss_tooling labels Aug 3, 2023
@martynydbt martynydbt removed the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants