Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for configure PrivateLink for VCS #4556

Merged
merged 16 commits into from
Dec 2, 2023
Merged

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Nov 29, 2023

What are you changing in this pull request and why?

Instructions for creating a PrivateLink connection for version control systems in VPC
https://dbtlabs.atlassian.net/browse/ENTERPRISE-1039

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@matthewshaver matthewshaver requested a review from a team as a code owner November 29, 2023 23:23
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 0:23am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Nov 29, 2023
@ajaythomas ajaythomas requested review from aaronbini and nm0s November 30, 2023 13:13

### Accepting the connection request

When you has been notified that the resources are provisioned within the dbt Cloud environment, you must accept the endpoint connection (unless the VPC Endpoint Service is set to auto-accept connection requests). Requests can be accepted through the AWS console as seen below, or through the AWS CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: When you has to When you have


<Lightbox src="/img/docs/dbt-cloud/cloud-configuring-dbt-cloud/accept-request.png" width="80%" title="Accept the connection request" />

Once the endpoint connection request is accepted, the PrivateLink endpoint is ready to use in dbt Cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need another section here that details what to do in dbt Cloud once the previous steps have been completed. This would be similar to the Create Connection in dbt Cloud sections in the pages for PrivateLink in Data Warehouses. The user will be able to use radio buttons to select "Private" and then be able to select the private endpoint from a dropdown. This is available in the Gitlab App Integration page, as well as in the form when selecting git over ssh.

@nm0s
Copy link
Contributor

nm0s commented Nov 30, 2023

This looks good to me!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matthewshaver I tried to reduce some of the wordiness and help clarify some steps. Let me know if you have any questions!

website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/secure/vcs-privatelink.md Outdated Show resolved Hide resolved

## Configure in dbt Cloud

Once the dbt Labs team confirms that the PrivateLink integration is complete, you can select it as part of a new or existing git configuration. Select **PrivateLink Endpoint** as the connection type, and your configured integrations will appear in the dropdown menu. This is a manual process; the existing connections remain configured as they were until this step is complete.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe as a 1st step, we can link them to how to set up their git integration? No need to repeat those steps but some might be confused.

@matthewshaver matthewshaver merged commit 18acc6f into current Dec 2, 2023
7 checks passed
@matthewshaver matthewshaver deleted the privatelink branch December 2, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants