Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-2426] [Feature] Add 'data_type' key to dimension spec #1287

Open
3 tasks done
Jstein77 opened this issue Jun 17, 2024 · 0 comments
Open
3 tasks done

[SL-2426] [Feature] Add 'data_type' key to dimension spec #1287

Jstein77 opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
backlog enhancement New feature or request Low priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@Jstein77
Copy link
Contributor

Jstein77 commented Jun 17, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

We should have a way to encode the data type of a column. We would update the dimension spec as follows:

dimensions:
 - name: [Required]
   type: [Required]
   data_type: [Optional] #the data type of the underlying column

This optional piece of metadata is useful in a few ways. It allows us to handle timezones and time type dimensions more easily, and can be used by integration partners to improve the user experience i.e using a boolean type filter instead of a string.

Describe alternatives you've considered

You could use the meta tag for this.

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-2426

@Jstein77 Jstein77 added enhancement New feature or request triage Tasks that need to be triaged labels Jun 17, 2024
@Jstein77 Jstein77 changed the title [Feature] Add 'data_type' key to dimension spec [SL-2426] [Feature] Add 'data_type' key to dimension spec Jun 17, 2024
@Jstein77 Jstein77 self-assigned this Jun 24, 2024
@Jstein77 Jstein77 added Metricflow Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request Low priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant