Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow variables in --start-time and --end-time #1533

Open
3 tasks done
siljamardla opened this issue Nov 15, 2024 · 0 comments
Open
3 tasks done

[Feature] Allow variables in --start-time and --end-time #1533

siljamardla opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement New feature or request triage Tasks that need to be triaged

Comments

@siljamardla
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

MetricFlow has validation rules on --start-time and --end-time.
If you enter something else, e.g. a string or variable, you will get an

Error: Invalid value for '--start-time': must be valid iso8601 timestamp

For the cases when we don't query, but simply compile the code, it would be very good to be able to override this validation. Specifically, we want to use variables in the output query. Example:

mf query --metrics my_metric --start-time DATE('{{ var("data_interval_start") }}') --explain

Describe alternatives you've considered

Compile the code and do a find-and-replace.

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@siljamardla siljamardla added enhancement New feature or request triage Tasks that need to be triaged labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant