Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back dedicated console window for non-release builds #3284

Open
DanAlbert opened this issue Dec 3, 2023 · 2 comments
Open

bring back dedicated console window for non-release builds #3284

DanAlbert opened this issue Dec 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@DanAlbert
Copy link
Member

https://www.pyinstaller.org/en/stable/spec-files.html#adding-parameters-to-spec-files shows that we can parameterize parts of the spec file. It'd probably be useful to bring the dedicated console window (the scrolling log window that isn't the one inside the liberation app). It went away in the first place because people complained about it being there, but we can keep it around for preview builds and just remove it in the release builds. The people that are more likely to need it are the people that are running the previews anyway.

@DanAlbert DanAlbert added the enhancement New feature or request label Dec 3, 2023
@Starfire13
Copy link
Contributor

Starfire13 commented Dec 3, 2023

Maybe just make it a toggle in the settings, default off, instead of removing it for release builds? Those who would actually want to use it would know how to toggle it on.

Edit: thinking about it more, perhaps it's just easier to remember to turn it off for release builds rather than to add the checkbox, and write the code to read/write it to/from settings file. Ultimately, it won't make all that much difference from the user's perspective.

@DanAlbert
Copy link
Member Author

Maybe just make it a toggle in the settings

We can't. It's either on or off per build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants