Make addon official

[seebeen]

Hello @rfay, @stasadev. I have another one for you 😅😅😅

[rfay]

First thing, of course, is standardized the schedule tests as in the other repo.
Please take a look to make sure all the files have #ddev-generated in them where they should.
Etc.

[stasadev]

It doesn't install on my Arch-based Linux, because I don't have this command:

./web-build/ioncube/download-loaders: line 4: /usr/bin/arch: No such file or directory

Maybe better use uname -m for the architecture check?

---

What about PHP 8.3 support?:

https://github.com/oblakstudio/ddev-ioncube/blob/76097833036585f32db93fd6d3281aa8989a0a88/web-build/ioncube/modify-dockerfile#L38

[rfay]

Could you please add more to the README (and maybe here) about why one would use ioncube stuff?

[rfay]

It looks like https://stackoverflow.com/questions/63390108/how-can-i-install-the-ioncube-loader-in-the-ddev-local-web-container should get an edited and improved answer! Sounds like you already have ARM64 (and they do also?)

[stasadev]

Ah, I see, there is no 8.3 support upstream https://www.ioncube.com/loaders.php

And yes, please tell us in more detail why we need this add-on to be official, because I believe that ionCube PHP Loader is used for production and DDEV is mainly used for local development.

Another thing to think about is that there is no mention in the README.md that the current installation technique is for Linux only.

[Snck3rs]

I can provide my use case for using ionCube in "development". We develop modules and individual solutions for a third party shop system. Some third party modules from specific developers rely on ioncube (i know - annoying thing) - so my local development environment of this shop is the mirrored production environment as i have no possibility to use the source code of the third party module. So i think, the use case for a official plugin would be something similiar.

[seebeen]

And yes, please tell us in more detail why we need this add-on to be official, because I believe that ionCube PHP Loader is used for production and DDEV is mainly used for local development.

Because there is a lot of systems which use IonCube as a protection mechanism. I namely develop plugins for WHMCS, SupportPal which are 99% encoded, and they require IonCube to work.

Additionally there are drupal modules, WP Plugins, even composer packages (hosted on packagist.com) which are encoded.

PHP 8.3 support is added (#52)
I track IonCube releases since I run a hosting company, and I usually update the loaders one week after release, because they sometimes have critical bugs.

Looking forward to additional feedback - and still hope to make this addon official 😊

[rfay]

It's fine, thanks for contributing and maintaining it. If you give me privs on it I'll move it and you can update it.

[rfay]

Moved to ddev org, please follow through with renaming and updating.

Please note @stasadev 's suggestion above too, thanks.

[seebeen]

Stanislav's change requests and suggestions have been implemented.
Editing readme.md now and pushing new version.

[rfay]

I see that the README has been updated, but I think it would be good to make a new release and close this issue.

[rfay]

And the tests haven't been updated, please take another pass through:

ddev-ioncube/tests/test.bats

Lines 61 to 62 in 6261d52

	echo "# ddev get oblakstudio/ddev-ioncube with project ${PROJECT} in ${TEST_DIR} ($(pwd))" >&3
	health_checks "oblakstudio/ddev-ioncube"

[rfay]

People have been asking for a release, so I went ahead and made one. Please do follow up on the issues shown here @seebeen , thanks!

• Update tests so they use the right repo
• Review tests to make sure they're doing enough and have 8.3 testing
• Review and respond to
  • Code of Conduct is incorrect #56
  • In adding a Dockerfile, why not just add a Dockerfile.ioncube ? #55

[seebeen]

Hola,

Had some more work than usual. Will review and update in the next couple of days.