Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fail_on_hook_fail: true for this integration #65

Open
rfay opened this issue Nov 28, 2022 · 0 comments
Open

Consider fail_on_hook_fail: true for this integration #65

rfay opened this issue Nov 28, 2022 · 0 comments

Comments

@rfay
Copy link
Member

rfay commented Nov 28, 2022

Over in

@flovntp pointed out a situation where the symfony-build fails, but the hooks continue on.

I think it would be reasonable to turn on fail_on_hook_fail: true for this integration, so later things don't show up from earlier failures.

I know there are a couple of places where the fails are inconsequential, but this is a situation where things should definitely stop and the failure should be pointed out where it actually is.

@rfay rfay changed the title Consider fail_on_hook_fail: true for this integraiton Consider fail_on_hook_fail: true for this integration Nov 28, 2022
rfay added a commit to rfay/ddev-platformsh that referenced this issue Dec 9, 2022
rfay added a commit to rfay/ddev-platformsh that referenced this issue Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant