Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider retiring ddev-proxy-support - should be obsolete #5

Open
rfay opened this issue Oct 30, 2022 · 5 comments
Open

Consider retiring ddev-proxy-support - should be obsolete #5

rfay opened this issue Oct 30, 2022 · 5 comments

Comments

@rfay
Copy link
Member

rfay commented Oct 30, 2022

It looks to me like

being solved may make this add-on obsolete, just as you signed on to maintainer @DaRealFreak ! My quick testing says that docker-compose now works with proxies without these aids.

Would appreciate if you could test using latest DDEV HEAD and see if you agree. brew install --HEAD --fetch-head ddev or grab binaries from https://github.com/drud/ddev/actions/runs/3355723146

See also

@DaRealFreak
Copy link
Collaborator

yes I tested it just now and can confirm that it also works for me

@rfay
Copy link
Member Author

rfay commented Jan 10, 2023

@rfay rfay changed the title ddev-proxy-support may be obsolete due to improved docker-compose Consider retiring ddev-proxy-support - should be obsolete Mar 5, 2023
@rfay
Copy link
Member Author

rfay commented Mar 5, 2023

I don't think we need this any more. If anybody is using, try not using it and see what happens.

@binary-data
Copy link

@rfay Please keep this one, if it doesn't require much maintenance!

I've tried using the Docker proxy configuration as described here: https://docs.docker.com/engine/cli/proxy/#configure-the-docker-client

However, this broke a couple of DDEV features, specifically:

So I resorted to using ddev-proxy-support and it worked! I could use DDEV as usual, and proxy settings worked. It was great to have a fallback option instead of spending more hours digging through Docker proxy settings.

@rfay
Copy link
Member Author

rfay commented Oct 14, 2024

Thanks @binary-data - I would have thought you could just used these env vars and everything would work, don't think you should have to make changes to docker proxy config.

HTTP_PROXY=yours
HTTPS_PROXY=yours
NO_PROXY=no-proxy-addrs
http_proxy=${HTTP_PROXY}

The docker CLI is not used here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants