Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary vs fivenum #32

Open
piccolbo opened this issue Nov 12, 2014 · 2 comments
Open

summary vs fivenum #32

piccolbo opened this issue Nov 12, 2014 · 2 comments

Comments

@piccolbo
Copy link
Contributor

The R summary is a fivenum summary + most common items counts for non numeric cols + count of NAs
A ddf fivenum is a fivenum summary + drop non-numeric cols + ignore NAs
A ddf summary is a method for a R base package generic and as such should be semantically close and if possible identical to the method for data.frames, particularly in this case where data frames in memory and distributed are implementation of the same abstraction (summary for vectors is by necessity a little different). Instead a ddf summary has: mean, min, max and count of NAs in common with R summary, stddev, count of rows, repeated for each column, and returns NAs for string columns (not even the rows that make sense, like count an cNA)

My suggestion is: keep fivenum what it is, since everybody knows the five num summary. Make summary a true method for base::summary results should be identical.

Add a function for momenta like mean, stddev, skewness, kurtosis etc

If the changes in the definition of summary should apply to other languages is a bit more subtle. I guess no one has the monopoly on the word summary. Unless there are specific expectation in Java or Python it'd be simpler to make them all the same. In R there are clear expectations for what summary should do.

@piccolbo
Copy link
Contributor Author

I see that also fivenum is a generic in R. But it doesn't drop any columns, it fails for non numeric cols.

@ctn
Copy link
Contributor

ctn commented Jun 4, 2015

@binhmop please look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants