Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foreign keys instead of simple-json to link messages with chats #1

Open
Manjit2003 opened this issue Aug 10, 2022 · 4 comments
Open
Assignees
Labels
enhancement New feature or request feature Self explanatory help wanted Extra attention is needed

Comments

@Manjit2003
Copy link

This will help easily define reverse relationship for messages.

@Manjit2003 Manjit2003 added the enhancement New feature or request label Aug 10, 2022
@deadlinecode
Copy link
Owner

Good idea
I also already thought of this but since this is the first version of the package i just tried to mimic the behaviour of the makeInMemory store from baileys which also isn't relational but yeah thanks for the suggestion

Would you be able to contribute and make a PR?

@deadlinecode deadlinecode added the help wanted Extra attention is needed label Aug 10, 2022
@Manjit2003
Copy link
Author

Yes surely, I will submit one soon. Just assign it to me

@deadlinecode
Copy link
Owner

Another thing:
I think theoretical we could include support for mongo db without a lot of rewriting since the only two relations are the MessageDic and PresenceDic once but if we make even the chats and everything relational we will prbbly forget about mongo db or nosql support

And also i think the primary keys need rewriting then because currently the behaviour is that one chat with a key can exist two times in the chat table

@deadlinecode deadlinecode added feature Self explanatory labels Jan 26, 2023
@deadlinecode
Copy link
Owner

Inconsistent data will be a huge problem when implementing this xD
Since wa only syncs what it likes to sync we will have a lot of missing contacts, chats, groups and much much more

wyuenchy referenced this issue in EPTHK/Whiskey-bottle Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Self explanatory help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants