Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to make <TextTicker> inaccessible to screen readers #109

Open
mitchdowney opened this issue Sep 4, 2021 · 1 comment
Open

Comments

@mitchdowney
Copy link

mitchdowney commented Sep 4, 2021

I'm trying to make the TextTicker not gain focus on Android when using a screen reader, but it doesn't look like TextTickerProps provides the option to override the accessible and importantForAccessibility props. Is it possible to make TextTicker inaccessible? Or would that need to be a new feature?

We have the accessibility text for our TextTicker set elsewhere in the UI when a screen reader is enabled, so it would be useful to prevent the TextTicker from gaining focus by the screenreader.

Thanks for writing this component. Other than this one thing it has worked perfectly for us.

@deanhet
Copy link
Owner

deanhet commented Sep 5, 2021

I don't see any reason why the current code shouldn't just work:

As I've linked, props that are passed to a normal text component are just passed straight through to the underlying text component of the the ticker. There's no magic to remove the props you've mentioned. Does your use case work with just a normal text component in its place instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants