Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking lower edge of checkbox toggles next checkbox #353

Open
robx opened this issue Aug 27, 2017 · 2 comments
Open

Clicking lower edge of checkbox toggles next checkbox #353

robx opened this issue Aug 27, 2017 · 2 comments

Comments

@robx
Copy link

robx commented Aug 27, 2017

I saw this while playing around with https://vipentti.github.io/elm-mdl-dashboard/:

When I click the bottom edge of a checkbox in the bottom right tile, the next checkbox is toggled instead of the one I click. This is with Safari. In the original dashboard at https://getmdl.io/templates/dashboard/index.html, the issue exists to a much smaller degree, if at all.

Apologies if this is just due to a newer MDL CSS version used at getmdl.io, I wouldn't know how to check that.

@SidneyNemzer
Copy link

SidneyNemzer commented Aug 29, 2017

It looks like this is related to the ripple effect for checkboxes; the ripples overlap, but the lower checkbox takes precedence because the height order of elements is reversed from their order in the DOM.

The Elm-MDL version behaves almost identically to the plain MDL version, for me at least.

@robx
Copy link
Author

robx commented Aug 29, 2017

Yes that seems right. The difference that I see between the two versions is that the elm-mdl one has ripples that overlap the adjacent checkboxes, while with the plain mdl one, they barely extend further than half-way between the checkboxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants