Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail Card #40

Open
nyssance opened this issue May 28, 2024 · 26 comments
Open

Detail Card #40

nyssance opened this issue May 28, 2024 · 26 comments
Labels
enhancement New feature or request

Comments

@nyssance
Copy link

nyssance commented May 28, 2024

I have migrated from other note apps to obsidian. I search a long time for a plugin that allows me to preview my notes just like in other apps. Now I find your project, which is very close to what I want. If you could provide a detail style like grid style but no spacing or very small spacing, displaying a bit of content, similar to Bear/Apple Notes/Evernote, and users can pin it to the left sidebar, it would perfectly replicate the structure of other note apps. believe this would be a feature that many people would need.

截屏2024-05-29 02 14 57
@decaf-dev
Copy link
Owner

I really like those cards! I will look into this. Thank you for the suggestion.

@javiavid
Copy link

Maybe this will help you create it.
https://github.com/xhuajin/obsidian-file-preview

I would love to see this option of showing some lines of content within your plugin, for me it is what I need to use it.

@decaf-dev
Copy link
Owner

Maybe this will help you create it. https://github.com/xhuajin/obsidian-file-preview

I would love to see this option of showing some lines of content within your plugin, for me it is what I need to use it.

That is helpful! Thanks

@Moyf
Copy link

Moyf commented Jun 13, 2024

https://github.com/daledesilva/obsidian_project-browser

Just remembered there is another project that also has similar functionality, maybe it will be helpful.

@decaf-dev decaf-dev added the enhancement New feature or request label Jun 23, 2024
@decaf-dev
Copy link
Owner

decaf-dev commented Jun 24, 2024

Added in 1.15.0

@Moyf
Copy link

Moyf commented Jun 25, 2024

Added in 1.15.0

AMAZING——

@Moyf
Copy link

Moyf commented Jun 25, 2024

Added in 1.15.0

AMAZING——

How to turn on it?
I cannot see the detail (content preview) in my Grid view, version: 1.16.0

@Moyf
Copy link

Moyf commented Jun 25, 2024

How to turn on it? I cannot see the detail (content preview) in my Grid view, version: 1.16.0

Just activated my Premium version and found out it's the new Feed view :D

And I think maybe we need some kind of Content Filter and Streaming Loading?

image
My personal Note's concept is a H1 same with the Filename in the front.
So I can only view the Header lol

I think maybe only view the Normal Text Content (Excludes table / callout / headers / ... ) as an optional ?

Also, let users choose *how much content (lines? character counts? not very sure...) * to preview?


And it seems now when switching into the Feed View, it would load all the notes at a time, which will cause a Freeze.

I don't know is it possible but could it be loaded "streamly"? Like when I view the first 25 notes, just loading 'em.
And when I scroll down, load the next notes.

It might be loaded several times, but perhaps separating loading can make the perception of lag less obvious? 🤔

Fixed in 1.17.1 !


BTW, could the Feed view also display a custom property (for example, description )?

Just a rough idea, maybe use some formatted text (similar to mustache language) to customize the displayed content.

{{prop:description}}
{{ content | noHeader | noTable | noCodeblock | noCallout }}

{{prop:xxx}} to display specific property, and {{ content }} for the note content, and use | noXX to exclude specific text content 🤔

@decaf-dev
Copy link
Owner

decaf-dev commented Jun 25, 2024 via email

@Moyf
Copy link

Moyf commented Jun 26, 2024

Are you using 1.17.1?

On Tue, Jun 25, 2024, 4:35 AM Moy @.> wrote: How to turn on it? I cannot see the detail (content preview) in my Grid view, version: 1.16.0 Just activated my Premium version and found out it's the new Feed view :D And I think maybe we need some kind of Content Filter and Streaming Loading? image.png (view on web) https://github.com/decaf-dev/obsidian-vault-explorer/assets/4013062/2b732968-3dd5-435b-9765-df234f785cdf My personal Note's concept is a H1 same with the Filename in the front. So I can only view the Header lol I think maybe only view the Normal Text Content (Excludes table / callout / headers / ... ) as an optional ? ------------------------------ And it seems now when switching into the Feed View, it would load all the notes at a time, which will cause a Freeze. I don't know is it possible but could it be loaded "streamly"? Like when I view the first 25 notes, just loading 'em. And when I scroll down, load the next notes. It might be loaded several times, but perhaps separating loading can make the perception of lag less obvious? 🤔 — Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTQYW7R6L5J5IYT64Q35TTZJFBWNAVCNFSM6AAAAABINN7MFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGU3DGMJSG4 . You are receiving this because you commented.Message ID: @.>

I was using 0.16.0 before, I will update it to see the effect.


Just updated to 1.17.2, it does not freeze when switching to Feed view now! 😄

@decaf-dev
Copy link
Owner

decaf-dev commented Jun 26, 2024 via email

@nyssance
Copy link
Author

nyssance commented Jun 27, 2024

I have same issue with @Moyf
My personal Note's also concept is a H1 same with the Filename in the front.
And some content such as banner before H1 but not in frontmatter.
So I want just show text after first H1。

And I also hope view the image.

If we can click on the entire card instead of just the link to enter the note, and add a right-click menu to facilitate deletion, the user experience would be greatly improved.

@decaf-dev
Copy link
Owner

@Moyf @nyssance Thanks for the feedback. I will add these as tasks.

@Moyf
Copy link

Moyf commented Jun 28, 2024

@Moyf @nyssance Thanks for the feedback. I will add these as tasks.

Oh since @nyssance mentioned the right-click menu, the other day when I was communicating with another plugin developer, he mentioned ModEvents which can add several common opening methods to the right-click menu. Perhaps VE can also consider incorporating it?
image

@nyssance
Copy link
Author

nyssance commented Jun 30, 2024

Maybe modevent is a good idea, but the priority of the right-click menu is not very high since its usage frequency is relatively low.

Now a new question after I installed 1.18.
It's display 250 characters in feed view now. My notes by English/Chinese, a Chinese character is approximately twice the width of an English character, the height of the feed card is too high, and only three cards can be displayed on the screen. Perhaps a configuration option to set the feed height or line count would be better, but I prefer not to configure it by character length. This solution would require converting character width from a development perspective, which is too complex.

Additionally, I would greatly appreciate it if the feed card could display the first image from the note (e.g., in a rectangle on the right side).

@decaf-dev
Copy link
Owner

decaf-dev commented Jul 6, 2024

@nyssance Please update to 1.21.2. I am looking for feedback on rendering the new line characters.

EDIT: it sounds like you want things as compact as possible?

@nyssance
Copy link
Author

nyssance commented Jul 7, 2024

@nyssance Please update to 1.21.2. I am looking for feedback on rendering the new line characters.

EDIT: it sounds like you want things as compact as possible?

Yes, after update to newest, now just show 1.2 feed per page。The feed height is too high.

@decaf-dev
Copy link
Owner

decaf-dev commented Jul 7, 2024 via email

@decaf-dev
Copy link
Owner

decaf-dev commented Jul 10, 2024

@nyssance Okay. I have added a setting called Collapse content that defaults to true. This will replace all new line characters with a single line break. I have also replaced the 250 character trimming with the -webkit-line-clamp property in css. This should make the correct measurement for unicode characters like Chinese.

Here is a description of the current line clamp behavior:

Screen size Class applied Number of lines
< 600px .vaultexplorer-feed-card__content--sm 2
>= 600px and < 1024px .vaultexplorer-feed-card__content--md 3
>= 1024px .vaultexplorer-feed-card__content--lg 5

Please upgrade to 1.24.0 and let me know if anything should be changed.

I will add an option for filtering markdown headers. And after that an attachment display similar to Bear notes. Thank you for the screenshots. They have been very helpful.

@nyssance
Copy link
Author

Perfect~

@decaf-dev decaf-dev mentioned this issue Jul 14, 2024
@decaf-dev
Copy link
Owner

@nyssance Added clickable content in 1.25.0. Will be enabled by default

@decaf-dev
Copy link
Owner

@nyssance @Moyf Okay. 1.27.0 includes a ton of updates for the feed view. A majority of Obsidian markdown is not being removed from the feed, including the first level headers (H1), so it looks a lot cleaner. I have also added settings for line clamping. The Collapse content setting has been changed to Collapse style. By default, everything is completely collapsed now with no new line characters, but you can set it to how it was in 1.25.0, with 1 new line character between every thing.

Please let me know what you think! :)

@nyssance
Copy link
Author

nyssance commented Jul 16, 2024

@decaf-dev Big Thanks for your amazing work. I think it is nearly perfect. If there is any improvement, it would be to hide all links, such as http://xxx, [xxx](https://xxx.com), ![image](xxx.jpg),these links are very long, but users click the feed to enter the note itself and do not need to jump to this link. They do not contain useful information.
Maybe all code blocks should be hidden too, such as $=dv.current is dataview code but not the note's info.

@nyssance
Copy link
Author

Additionally, there's a small issue regarding tags. If a tag contains subtags, such as #aaa/bbb, a better approach would be to display only #bbb. However, I think this feature should be implemented by the Obsidian team.

@Moyf
Copy link

Moyf commented Jul 16, 2024

@nyssance @Moyf Okay. 1.27.0 includes a ton of updates for the feed view. A majority of Obsidian markdown is not being removed from the feed, including the first level headers (H1), so it looks a lot cleaner. I have also added settings for line clamping. The Collapse content setting has been changed to Collapse style. By default, everything is completely collapsed now with no new line characters, but you can set it to how it was in 1.25.0, with 1 new line character between every thing.

Please let me know what you think! :)

AMAZING!! Really love it <3
Now I can easily review many notes in Vault Explorer, really good experience !
Good Job!

@Moyf
Copy link

Moyf commented Jul 16, 2024

After experiencing it, there are two things:

  1. When switching back from other tabs, there will be obvious lag;
  2. I will use more than 3 tick characters (`), but they will not be cleaned up properly. It is recommended to use "≥ 3 tick code blocks" for deletion (see picture).
    image

Also, I hope that the Grid view supports displaying the first image in the note, not just the image link in the image attribute.
And I hope that images can be set to display in a specific way: constrain(maintain aspect ratio) or fill (horizontally tile):
image

image


Additionally, I would like to provide an alternative option to display using title instead of the file name. But this one is not very important I think... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants