feat: add auth dapp flow #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2023 20:28
Test this pull requestThis branch can be previewed at |
added 8 commits
December 28, 2023 15:05
meelrossi
force-pushed
the
feat/auth-login-dapps
branch
2 times, most recently
from
ce03390 to
74cb8a4
Compare
meelrossi
force-pushed
the
feat/auth-login-dapps
branch
from
74cb8a4 to
b9134d4
Compare
fzavalia
suggested changes
Jan 1, 2024
src/components/start/Start.tsx
Outdated
| <WearablePreview | ||
| profile={wallet?.address} | ||
| disableBackground | ||
| dev={getWantedChainId() === ChainId.ETHEREUM_SEPOLIA} |
There was a problem hiding this comment.
Use !== ETHEREUM_MAINNET instead to make it easier in case the testnet is changed
src/integration/url.ts
Outdated
| @@ -2,11 +2,13 @@ const qs = new URLSearchParams(document.location.search || '') | |||
| export const DEBUG_ANALYTICS = qs.has('DEBUG_ANALYTICS') | |||
| export const SHOW_WALLET_SELECTOR = qs.has('show_wallet') | |||
| export const ENV = qs.get('ENV') | |||
| export const NETWORK = qs.get('NETWORK') | |||
| export const NETWORK = qs.get('NETWORK') || qs.get('network') | |||
src/state/selectors.ts
Outdated
| @@ -12,6 +12,7 @@ export function getRequiredAnalyticsContext(state: StoreType): SessionTraits { | |||
|
|
|||
| export enum FeatureFlags { | |||
| Stream = 'explorer-stream', | |||
| AuthDapp = 'auth-dapp', | |||
There was a problem hiding this comment.
I think you need to add the prefix of the feature flag. dapps-auth-dapp
fzavalia
approved these changes
Jan 1, 2024
meelrossi
pushed a commit
that referenced
this pull request
Jan 9, 2024
This reverts commit 16f8d79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add login with auth dapp