-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guidance for recommending fully qualified URIs for all properties, not just keys #130
Comments
@decentralgabe I agree that when expanding a DID identifier to a DID document, DID DHT implementations should use full DID URLs (i.e., that begin with However, in the case of custom properties added to a The DID Core spec allows for DID Relative URLs and contains guidance on how to resolve a relative DID URL reference.
It appears the authors of the DID spec included relative DID URLs for precisely the purpose in which we're using them: to optimize storage size
|
Agree with your reasoning, but not sure I agree with your conclusion. Yes, it is allowed by the DID Core spec. @andresuribe87 made a suggestion to always include fully qualified URLs to make implementations consistent and unambiguous, which I implemented. We could reverse course here and do the opposite: always use fragments. I am less concerned with the size of documents once expanded, and more concerned with interoperability. The code to reconstruct verification methods based on variation in DID Documents can be really complex which is part of my motivation here. So, while I agree there isn't anything wrong per say, I do think implementations benefit from consistency = simplicity. And this is a bubble where we can force that consistency. |
Aligned and 👍 to adding language to the spec stating that service ID values will always be expanded to a fully qualified DID URLs. Custom properties that appear in a |
generally I think we should avoid fragments with # since - at least to me - they only make sense in the context of a full identifier
Originally posted by @decentralgabe in decentralized-identity/web5-js#413 (comment)
The text was updated successfully, but these errors were encountered: