Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with the did peer specs in the 'serviceEndpoint' #438

Open
FabioPinheiro opened this issue Apr 5, 2023 · 3 comments
Open

Comments

@FabioPinheiro
Copy link
Contributor

In the DID Document the JSON path service.serviceEndpoint
The examples on this specs are incompatible with the did peer specs

{
    "id": "did:example:123456789abcdefghi#didcomm-1",
    "type": "DIDCommMessaging",
    "serviceEndpoint": {
        "uri": "https://example.com/path",
        "accept": ["didcomm/v2","didcomm/aip2;env=rfc587"],
        "routingKeys": ["did:example:somemediator#somekey"]
    }
}

https://identity.foundation/peer-did-method-spec/#multi-key-creation

{
  "id": "did:peer:2.E....#didcommmessaging-0",
  "type": "DIDCommMessaging",
  "serviceEndpoint": "https://example.com/endpoint",
  "routingKeys": ["did:example:somemediator#somekey"],
  "accept": ["didcomm/v2", "didcomm/aip2;env=rfc587"]
}
@FabioPinheiro
Copy link
Contributor Author

FabioPinheiro commented Oct 27, 2023

The peer-did-method was addressed by PR decentralized-identity/peer-did-method-spec#62

This was also fixed on the did-core-spec

But we still need to fix on did-spec-registries

@TelegramSam
Copy link
Collaborator

PR needed on this repo: https://github.com/w3c/did-spec-registries/

@FabioPinheiro
Copy link
Contributor Author

Here is the PR w3c/did-extensions#548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants