Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordDelete is not being received in a subscription when it is expected #759

Open
Tracked by #806
LiranCohen opened this issue Jun 13, 2024 · 1 comment
Open
Tracked by #806
Labels
bug Something isn't working hacktoberfest For the hacking month of October

Comments

@LiranCohen
Copy link
Member

Example Scenario:

  1. Bob installs the chat protocol and creates a thread, adding Alice as a participant.
  2. Alice creates a subscription to receive events using the delegated grant.
  3. Bob writes two chat messages to the thread.
  4. Bob deletes one of the chat messages.

Expected: The subscription handler should have received both the chat writes and the delete.
Actual: The subscription received only the writes.

When subscribing using protocol rules, a set of filters are built to match against the indexes created when storing the Delete.
Investigate modifying the filters/indexing to allow for the expected behavior.

@LiranCohen LiranCohen added the bug Something isn't working label Jun 13, 2024
@thehenrytsai thehenrytsai added this to DWN Jun 17, 2024
@thehenrytsai thehenrytsai added the hacktoberfest For the hacking month of October label Sep 13, 2024
@naaa760
Copy link

naaa760 commented Oct 24, 2024

Hello @LiranCohen :)

I think to * Update Subscription Filters: Add the RecordWrite and RecordDelete event types to the filters.

{ "eventType": ["RecordWrite", "RecordDelete"], ... }
  • Check Indexing: As with RecordWrite events, make sure RecordDelete events are appropriately indexed.

  • Test: Make that the subscription now records both write and delete events by simulating the deletion of messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest For the hacking month of October
Projects
None yet
Development

No branches or pull requests

3 participants