From 58cb180307530bec14bb0ada9a4fc15486754bff Mon Sep 17 00:00:00 2001 From: Henry Tsai Date: Mon, 1 Jul 2024 10:17:07 -0700 Subject: [PATCH] addressed PR comments --- src/web5-connect/sql-ttl-cache.ts | 3 --- src/web5-connect/web5-connect-server.ts | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/web5-connect/sql-ttl-cache.ts b/src/web5-connect/sql-ttl-cache.ts index e1e993a..4a0bef1 100644 --- a/src/web5-connect/sql-ttl-cache.ts +++ b/src/web5-connect/sql-ttl-cache.ts @@ -68,9 +68,6 @@ export class SqlTtlCache { * Retrieves a cache entry if it is not expired and cleans up expired entries. */ public async get(key: string): Promise { - // clean up expired entries but no need to await for it to finish - this.cleanUpExpiredEntries(); - const result = await this.db .selectFrom(SqlTtlCache.cacheTableName) .select('key') diff --git a/src/web5-connect/web5-connect-server.ts b/src/web5-connect/web5-connect-server.ts index 26ef22a..df158d0 100644 --- a/src/web5-connect/web5-connect-server.ts +++ b/src/web5-connect/web5-connect-server.ts @@ -40,6 +40,7 @@ export class Web5ConnectServer { * Creates a new instance of the Web5 Connect Server. * @param params.baseUrl The the base URL of the connect server including the port. * This is given to the Identity Provider (wallet) to fetch the Web5 Connect Request object. + * @param params.sqlTtlCacheUrl The URL of the SQL database to use as the TTL cache. */ public static async create({ baseUrl, sqlTtlCacheUrl }: { baseUrl: string;