Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CORS tests hide console errors and don't set them back. #112

Open
LiranCohen opened this issue Feb 15, 2024 · 0 comments
Open

The CORS tests hide console errors and don't set them back. #112

LiranCohen opened this issue Feb 15, 2024 · 0 comments

Comments

@LiranCohen
Copy link
Member

Within the cors.spec.ts file there are lines that set the console(log, error, info) to void functions in order to hide them in testing.
However they are never re-assigned.

https://github.com/TBD54566975/dwn-server/blob/main/tests/cors.spec.ts#L176-L178

Fix this issue to re-assign console.log. As well as make sure that purposeful logging throughout the system uses the loglevel package for logging. And also disable this specific log in tests as it might be too noisy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant