Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct use of default config to avoid config changes bleed/pollute between tests #144

Open
thehenrytsai opened this issue Jul 10, 2024 · 0 comments
Open

Remove direct use of default config to avoid config changes bleed/pollute between tests #144

thehenrytsai opened this issue Jul 10, 2024 · 0 comments
Labels
good first issue Good for newcomers test Test related issue.

Comments

@thehenrytsai
Copy link
Collaborator

Remove direct use of default config to avoid config changes bleed/pollute between tests, should clone before modify.

See http-api.spec.ts as a prime example of misuse. As a results, tests like dynamic-plugin-loading.spec.ts need to override the config explicitly to ensure reliability.
@thehenrytsai thehenrytsai added good first issue Good for newcomers test Test related issue. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test Test related issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehenrytsai