From b2824b615d352938827372dc0dec4ebf46701f60 Mon Sep 17 00:00:00 2001 From: Leo Ribeiro Date: Tue, 7 May 2024 17:56:49 -0400 Subject: [PATCH] Remove unnecessary api release protection (#517) * Remove unnecessary api release protection * Fix changeset check script * Cleanup --- .changeset/old-hotels-yawn.md | 1 - .github/workflows/release.yml | 1 - scripts/changesets-api-release-check.sh | 5 +++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.changeset/old-hotels-yawn.md b/.changeset/old-hotels-yawn.md index 4c00a3c49..23499b9cd 100644 --- a/.changeset/old-hotels-yawn.md +++ b/.changeset/old-hotels-yawn.md @@ -11,4 +11,3 @@ Server Info includes: - maxFileSize - registrationRequirements - webSocketSupport - diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8bd11f3e5..78e32ebe5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -77,7 +77,6 @@ jobs: - name: Create Release Pull Request or Publish to npm uses: changesets/action@aba318e9165b45b7948c60273e0b72fce0a64eb9 # v1.4.7 id: changesets - if: steps.check_api_release.outputs.skip_release != 'true' with: publish: pnpm changeset publish version: scripts/changesets-version.sh ${{ steps.check_api_release.outputs.release_web5_api || '' }} diff --git a/scripts/changesets-api-release-check.sh b/scripts/changesets-api-release-check.sh index 2606e0dd6..6265b8e69 100755 --- a/scripts/changesets-api-release-check.sh +++ b/scripts/changesets-api-release-check.sh @@ -38,8 +38,9 @@ fi if [[ $API_RELEASES_COUNT == $ALL_RELEASES_COUNT ]]; then echo "Only @web5/api release detected, checking for API Release labeled PR or Kick trigger..." if [[ -z $RELEASE_WEB5_API ]]; then - echo "No API Release labeled PR found and KICK_API_RELEASE is false, skipping the release..." - echo "skip_release=true" >> $GITHUB_OUTPUT + echo "No API Release labeled PR found and KICK_API_RELEASE is false, skipping the PR creation..." + # removes all the api changesets files to ensure a Version Packages PR is not created + find .changeset -type f -name "*.md" ! -name "README.md" -exec rm {} + exit 0 fi fi