-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section for explanation of External Links and the Allow External Domains feature #153
Comments
Hi folks! The term 'whitelist' has long been determined a racist term and shouldn't have a place in open source software. Happy to make a PR to change this, if it will be acceptable. cc @decidim/product Perhaps we can consider using 'allow list' instead. |
Hi @RCheesley thanks for bringing attention to this, I was not aware of that conversation in software. Changing the title but leaving the rest for reference, however we may need to move this part of the conversation to the main repo because this repo is about documentation. What do you think, @carolromero ? I believe the term exists only on this screen as well as the rails route: /admin/organization/external_domain_whitelist/ |
Hi @basicavisual and @RCheesley! Thank you for the heads up. A while back we made some name changes, like the GitHub repository itself (which used to be called Master), and so on, but this one had slipped our minds. As Ali mentions, a PR would need to be submitted to the main repo. Doing a quick search for strings I think this is the only place. |
FYI this was tracked at decidim/decidim#6678 I'll handle the fix so we can close that issue |
Fixed and available in Nightly: https://nightly.decidim.org/admin/organization/external_domain_allowlist/edit |
When you post an external link anywhere on the site, the link will have an external link icon, and when clicking it, it will show a modal.
To avoid this modal on specific domains, decidim has implemented a whitelist feature on the admin panel at: https://try.decidim.org/admin/organization/external_domain_whitelist/
This issue is to propose a new section or sub-page to document this feature.
The text was updated successfully, but these errors were encountered: