Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Object files are grouped into the same family even if targeting different functions #1281

Open
NWPlayer123 opened this issue Jun 15, 2024 · 0 comments

Comments

@NWPlayer123
Copy link
Contributor

Describe the bug
This is mostly a consequence of objdiff's decomp.me integration. Since it uploads the entire TU as a .o, decomp.me will treat all scratches as the same family even if the user is trying to diff a different function

To Reproduce
Import two different functions from the same TU using the 📲 decomp.me button in objdiff

Expected behavior
Functions to be treated as different even if they use the same .o as the diff label is different and it hides all asm but the one being targeted, so a normal user would just see the function they're working on without it being grouped with other functions in the same TU.

Screenshots
If applicable, add screenshots to help explain your problem.

Scratches
https://decomp.me/scratch/Boslo
https://decomp.me/scratch/6Ne1Z
https://decomp.me/scratch/3UXlj
https://decomp.me/scratch/sK4Rb

Desktop (please complete the following information if applicable):
Windows 10 22H2, Firefox v127

Additional context
Relevant Discord discussion
Something else to think about, per @1superchip (link), more flexibility in family might be good, or finally rolling out game-specific projects as was experimented with on Paper Mario 64 as it would allow grouping together multiple platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant