Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpecExamplesITCase.java:45-49: Add more tests to cover... #336

Closed
0pdd opened this issue May 13, 2020 · 5 comments
Closed

SpecExamplesITCase.java:45-49: Add more tests to cover... #336

0pdd opened this issue May 13, 2020 · 5 comments

Comments

@0pdd
Copy link

0pdd commented May 13, 2020

The puzzle 238-cdc69ab7 from #238 has to be resolved:

* @todo #238:30min Add more tests to cover all the examples from the Yaml 1.2
* Specification. You can have a look at PR 335 to see how other examples have
* been tested. Don't forget that you do not have to write all the tests in
* this task -- write 1 or 2 tests, leave a todo (puzzle) and the work will
* continue in a future ticket.

The puzzle was created by @ANadrowski on 13-May-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Author

0pdd commented May 13, 2020

@amihaiemil please pay attention to this new issue.

@ANadrowski
Copy link
Contributor

Hi @amihaiemil I'd like to add more 3 spec example tests. Could you assign it to me?

@ANadrowski
Copy link
Contributor

@amihaiemil just sent a PR, please take a look :)

@0pdd 0pdd closed this as completed May 15, 2020
@0pdd
Copy link
Author

0pdd commented May 15, 2020

The puzzle 238-cdc69ab7 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

@0pdd
Copy link
Author

0pdd commented May 15, 2020

@0pdd the puzzle #338 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants