Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting features with BBOX returns features outside BBOX #100

Open
dstenger opened this issue Jul 12, 2023 · 2 comments
Open

Requesting features with BBOX returns features outside BBOX #100

dstenger opened this issue Jul 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@dstenger
Copy link
Contributor

Describe the bug
Requesting features with a request containing a BBOX returns features which are not located inside the BBOX.

The behavior was detected with the reference implementation: http://cite.deegree.org/deegree-ogcapi-1.3/datasets/kitaeinrichtung/

To Reproduce
Steps to reproduce the behavior:

  1. Send request: http://cite.deegree.org/deegree-ogcapi-1.3/datasets/kitaeinrichtung/collections/KitaEinrichtungen/items?f=json&bbox=177.0000000,65.0000000,-177.0000000,70.0000000
  2. Compare returned features with BBOX of request:
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "id": "APP_KITAEINRICHTUNGEN_1010263",
      "geometry": {
        "type": "Point",
        "coordinates": [
          10.010474613490274,
          53.60929655136682
        ]
      },
...

Expected behavior
Only features located inside the BBOX shall be returned.

Additional context
This error was detected via the OGC CITE ETS using the code provided by this PR: opengeospatial/ets-ogcapi-features10#220

@dstenger dstenger added the bug Something isn't working label Jul 12, 2023
@tfr42 tfr42 added this to the 1.3.0 milestone Nov 2, 2023
@tfr42 tfr42 modified the milestones: 1.3.0, 1.3.1 Dec 4, 2023
@dstenger
Copy link
Contributor Author

dstenger commented Jan 8, 2024

Mandatory test validate Features With Bounding Box Response of OGC test suite is currently failing.

@tfr42 tfr42 modified the milestones: 1.3.1, 1.3.0 Mar 6, 2024
@stephanr
Copy link
Member

stephanr commented Mar 6, 2024

In the past, a similar issue happened in a web app I was working on.
Solving the issue correct can be really difficult as multiple components are affected (databases, dependencies, core geometry stuff).
In the web app, this was solved by using a workaround which split the bbox in half at the overlap line.
But this requires the possibility to split the bbox in two halves internally and use it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants