Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty localstorage #29

Open
UmangThapliyal opened this issue Feb 22, 2022 · 7 comments
Open

handle empty localstorage #29

UmangThapliyal opened this issue Feb 22, 2022 · 7 comments
Assignees

Comments

@UmangThapliyal
Copy link
Contributor

UmangThapliyal commented Feb 22, 2022

Currently we will initialize the var as empty string and we are checking the length of itinstead we should check the value. There are two condition currently where when we are running in browser we are taking it as string because localstorage and when in node we are taking as array because there we have variable we need to make sure we are using one data type

@UmangThapliyal UmangThapliyal self-assigned this Feb 22, 2022
UmangThapliyal pushed a commit that referenced this issue Feb 22, 2022
UmangThapliyal added a commit that referenced this issue Feb 22, 2022
@UmangThapliyal
Copy link
Contributor Author

after addong the condition not getting other logs checking this

@UmangThapliyal
Copy link
Contributor Author

the issue was because of the js closure where the function will have different scope we have to bind this to the function and then call it

UmangThapliyal pushed a commit that referenced this issue Feb 22, 2022
UmangThapliyal added a commit that referenced this issue Feb 22, 2022
@UmangThapliyal
Copy link
Contributor Author

given pr and merged

@purushothaman-source
Copy link
Contributor

snoozing this

@purushothaman-source
Copy link
Contributor

snoozing this

@prashanthellina
Copy link
Member

@purushothaman-source The issue title and description aren't making any sense to me. Do you know what this means?

@purushothaman-source
Copy link
Contributor

updated brielfy in #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants