-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle empty localstorage #29
Labels
Comments
UmangThapliyal
pushed a commit
that referenced
this issue
Feb 22, 2022
after addong the condition not getting other logs checking this |
the issue was because of the js closure where the function will have different scope we have to bind this to the function and then call it |
UmangThapliyal
pushed a commit
that referenced
this issue
Feb 22, 2022
UmangThapliyal
added a commit
that referenced
this issue
Feb 22, 2022
ref #29, added bind to function
given pr and merged |
UmangThapliyal
added
moveto-inprogress-2w
ready-status
and removed
inprogress-status
labels
Feb 23, 2022
purushothaman-source
added
snooze-3m
and removed
inprogress-status
moveto-inprogress-2w
labels
Oct 20, 2022
snoozing this |
|
@purushothaman-source The issue title and description aren't making any sense to me. Do you know what this means? |
updated brielfy in #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we will initialize the var as empty string and we are checking the length of itinstead we should check the value. There are two condition currently where when we are running in browser we are taking it as string because localstorage and when in node we are taking as array because there we have variable we need to make sure we are using one data type
The text was updated successfully, but these errors were encountered: