Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GQL_URN to DEEPLINKS_GQL_PATH, and GQL_SSL to DEEPLINKS_GQL_SSL across all repositories #176

Open
Konard opened this issue Oct 9, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Konard
Copy link
Member

Konard commented Oct 9, 2023

URN is for books and standards. To use for for GQL path/url is just wrong.

https://stackoverflow.com/questions/57446486/name-of-the-portion-of-a-url-that-follows-the-scheme
https://stackoverflow.com/a/38204721/710069
https://www.rfc-editor.org/rfc/rfc3986#section-4.2

Screenshot_20231012_225832

The closest idea is relative reference of URL, but it contains // which we don't use in GQL_URN env.

Other variations:

UriWithoutSchema
UrlWithoutSchema
AuthorityWithPath

SCHEMELESS_URL

And may be we should use even better way to do it: deep-foundation/hasura#15 (this way may be optional)

@Konard Konard added the bug Something isn't working label Oct 9, 2023
@Konard Konard self-assigned this Oct 9, 2023
@Konard Konard moved this to Todo in Deep Architecture Oct 9, 2023
@Konard
Copy link
Member Author

Konard commented Oct 9, 2023

@ivansglazunov do you have arguments against breaking change here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant