Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TURN creds #77

Open
abergdesign opened this issue Mar 4, 2021 · 4 comments
Open

Adding TURN creds #77

abergdesign opened this issue Mar 4, 2021 · 4 comments
Assignees
@deepch
Labels
enhancement New feature or request

Comments

@abergdesign
Copy link

Hi,
could I add a TURN server to the ICE Servers? I spent an hour on it but didn't get anywhere.
Thank you for a great project!
Ulf
@deepch deepch self-assigned this Mar 21, 2021
@deepch deepch added the enhancement New feature or request label Mar 21, 2021
@danbao12138 danbao12138 mentioned this issue Apr 12, 2021
Open
@tfmeneses
Copy link

Hi @deepch ,

I'm using the pion/turn.

Do you have any idea how to implement this? I can observe that we need to change the ICE Server struct, right?

@abergdesign
Copy link
Author

Hi both,

I now think a turn server will only make sense if the server code can be separated from the "peer" code (which is reading the rtsp stream), so those two functions (server and peer) can run on different machines. Otherwise stun is enough since a server will always be reachable by any browser clients by default. Am I right in this assumption?

My use case is an IP cam on a LAN with an edge device (think raspberry pi) on a LAN that cannot be accessed from the internet and no port forwarding is available since it is over a cellular network. I'd need the rtsp code/webRTC peer on the edge and the server code on the internet.
Many thanks!

@travishaagen
Copy link
Contributor

travishaagen commented Apr 19, 2021 •
edited
Loading

@deepch I can put up a PR shortly. Done.

travishaagen added a commit to travishaagen/RTSPtoWebRTC that referenced this issue Apr 19, 2021
@travishaagen
Ability to define TURN server credentials (deepch#77)
5b27abd
deepch added a commit that referenced this issue Apr 19, 2021
@deepch
Merge pull request #92 from travishaagen/turn_creds_issue77
7577540 
Ability to define TURN server credentials (#77)
@abergdesign
Copy link
Author

Thank you! Can you confirm if it is possible to run the server code on a separate machine from the RTSP/peer code? The machine having access to the RTSP stream is not exposed to the internet.
Many thanks,
Ulf
Aberg Design

rancococ added a commit to rancococ/RTSPtoWebRTC that referenced this issue Apr 26, 2021
@rancococ @Emalton
@deepch @osos @Devirex @vdalex25 @AlexxIT @FourLeafTec @travishaagen
update from oirgin (#1)
fcc4f80 
* Update README.md

Changed "go run *.go" to "go run ." per stackoverflow.com/q/23695448

* pcm audio support

* license add

* readme update

* ffffff

* fix work safari and firefox

* update run / build instructions

could not build or run without enabling go modules

* fix err

* pion v3 test

* rtspv2 upgrade

* rtspv2 upgrade

* add audio support pcm

* fix missing mod sum

* opus work in progress

* opus codec worked

* combined video and audio, add option ice_servers, on_demand

* fix typo deepch#44

* fix absolute patch

* fix ... typo

* Update README.md

* add header

* add more options debug, disable_audio

* add more options debug, disable_audio

* test bad sps pps

* fix bug

* Add support config from console

* Add support instant url handle

* Support optional web folder

* Add build.bat

* Fix default ICE servers

* Fix check web folder exists

* Add darwin and i386 archs

* Update gitignore

* fix cors

fix cors with chrome default option Referrer-Policy: strict-origin-when-cross-origin
See [go-gin-framework-cors](https://stackoverflow.com/questions/29418478/go-gin-framework-cors)

* Ability to define TURN server credentials (deepch#77)

* Update app.js

* Fix OnDemand stream exit

* mod update

* Update command line parsing

* Return RTSP errors to the client

* ping pong remove

* Fix darwin build command

Co-authored-by: John P <[email protected]>
Co-authored-by: Andrey Semochkin <[email protected]>
Co-authored-by: Andrey Semochkin <[email protected]>
Co-authored-by: osos <[email protected]>
Co-authored-by: Andrey Semochkin <[email protected]>
Co-authored-by: Devirex <[email protected]>
Co-authored-by: vdalex25 <[email protected]>
Co-authored-by: Alexey Khit <[email protected]>
Co-authored-by: FourLeafTec <[email protected]>
Co-authored-by: Travis Haagen <[email protected]>
Co-authored-by: Dmitriy Vladykin <[email protected]>
@tfmeneses tfmeneses mentioned this issue May 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepch deepch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@travishaagen @deepch @tfmeneses @abergdesign