Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrage Snapshot DHC Breaking Change #194

Closed
stanbrub opened this issue Oct 19, 2023 · 0 comments · Fixed by #195
Closed

Barrage Snapshot DHC Breaking Change #194

stanbrub opened this issue Oct 19, 2023 · 0 comments · Fixed by #195
Assignees
Labels
bug Something isn't working

Comments

@stanbrub
Copy link
Collaborator

DHC 0.29.0 introduced a known breaking change the requires upgrading to deephaven-java-client-barrage-dagger:0.29.0. This is captured here: #192.

After upgrading Benchmark to use the new barrage dagger version, a problem was discovered with table snapshots where a table name and column names could be retrieved through the barrage client that contained no rows. Below are the tickets capturing that issue for deephaven-core.

A workaround was offered that is more like the fetchDuration support in Benchmark. This is stated to be more efficient and looks cleaner that the broken way of doing snapshots.

From Nate's investigation: I appear to be able to reproduce. A work around is to use BarrageSession#subscribe (instead of snapshot) and then invoke snapshotEntireTable instead of entireTable (or snapshotPartialTable if that is what you are doing).

@stanbrub stanbrub added the bug Something isn't working label Oct 19, 2023
@stanbrub stanbrub linked a pull request Oct 20, 2023 that will close this issue
@stanbrub stanbrub self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant