From 564530c9c2d47f330bb9cb0333d3112370bd6101 Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Wed, 15 Nov 2023 13:19:59 -0800 Subject: [PATCH] Review response --- .../main/java/io/deephaven/kafka/KafkaPublishOptions.java | 6 +++--- py/server/deephaven/stream/kafka/producer.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/extensions/kafka/src/main/java/io/deephaven/kafka/KafkaPublishOptions.java b/extensions/kafka/src/main/java/io/deephaven/kafka/KafkaPublishOptions.java index 74acab261f0..79d9d436e2b 100644 --- a/extensions/kafka/src/main/java/io/deephaven/kafka/KafkaPublishOptions.java +++ b/extensions/kafka/src/main/java/io/deephaven/kafka/KafkaPublishOptions.java @@ -120,9 +120,9 @@ public boolean publishInitial() { /** * The partition column. When set, uses the the given {@code int} column from {@link #table()} as the first source * for setting the kafka record partition. When not present, or the column value is null, {@link #partition()} will - * be used if present. If a valid partition number is specified that partition will be used when sending the record. - * If no partition is specified but a key is present a partition will be chosen using a hash of the key. If neither - * key nor partition is present a partition will be assigned in a round-robin fashion. + * be used if present. If a valid partition number is specified, that partition will be used when sending the + * record. If no partition is specified but a key is present, a partition will be chosen using a hash of the key. If + * neither key nor partition is present, a partition will be assigned in a round-robin fashion. * * @return the partition column name */ diff --git a/py/server/deephaven/stream/kafka/producer.py b/py/server/deephaven/stream/kafka/producer.py index 0f530a041c9..77ff9ee5c02 100644 --- a/py/server/deephaven/stream/kafka/producer.py +++ b/py/server/deephaven/stream/kafka/producer.py @@ -72,9 +72,9 @@ def produce( will be used. partition_column (Optional[str]): the partition column, None by default. When set, uses the the given int column from table as the first source for setting the kafka record partition. When None, or the column value is null, - partition will be used if present. If a valid partition number is specified that partition will be used when - sending the record. If no partition is specified but a key is present a partition will be chosen using a hash - of the key. If neither key nor partition is present a partition will be assigned in a round-robin fashion. + partition will be used if present. If a valid partition number is specified, that partition will be used when + sending the record. If no partition is specified but a key is present, a partition will be chosen using a hash + of the key. If neither key nor partition is present, a partition will be assigned in a round-robin fashion. timestamp_column (Optional[str]): the timestamp column, None by default. When set, uses the the given timestamp column from table as the first source for setting the kafka record timestamp. When None, or the column value is null, the producer will stamp the record with its current time. The timestamp eventually used by Kafka