From 9275306ab0f03dd96550734dc6c797b6c1ba72eb Mon Sep 17 00:00:00 2001 From: Colin Alworth Date: Fri, 13 Oct 2023 13:04:52 -0500 Subject: [PATCH] Always half-close DoExchange snapshot requests (#4632) Partial mitigation for #4627 --- .../java/io/deephaven/client/impl/BarrageSnapshotImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java b/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java index d7aeddfebdf..1cf704e6aa6 100644 --- a/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java +++ b/java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSnapshotImpl.java @@ -201,6 +201,8 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b .setAppMetadata(ByteStringAccess.wrap(makeRequestInternal(viewport, columns, reverseViewport, options))) .build()); + observer.onCompleted(); + while (!completed && exceptionWhileCompleting == null) { // handle the condition where this function may have the exclusive lock if (completedCondition != null) { @@ -210,8 +212,6 @@ public synchronized BarrageTable partialTable(RowSet viewport, BitSet columns, b } } - observer.onCompleted(); - if (exceptionWhileCompleting == null) { return resultTable; } else {