Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrage Client Leaks Memory with Some Index Patterns #5035

Closed
cpwright opened this issue Jan 12, 2024 · 1 comment · Fixed by #5038
Closed

Barrage Client Leaks Memory with Some Index Patterns #5035

cpwright opened this issue Jan 12, 2024 · 1 comment · Fixed by #5038
Assignees
Labels
barrage bug Something isn't working core Core development tasks java-client query engine

Comments

@cpwright
Copy link
Contributor

Description

A clear and concise description of what the bug is.

Produce the following table:

sourceTable = timeTable("PT0.001s").tail(1000)
st = new Table[64]
for (int ii = 0; ii < st.length; ++ii) {
    st[ii] = sourceTable
}
m = merge(st)

Subscribe to it. The redirection index in the barrage client table grows because we cycle through the indices; and the SparseArraySource backing it does not know that the block is now null and meaningless.

Versions

  • Deephaven: ...
  • OS: ...
  • Browser: ...
  • Docker: ...
@cpwright cpwright added bug Something isn't working triage labels Jan 12, 2024
@rcaudy rcaudy added barrage query engine core Core development tasks java-client and removed triage labels Jan 12, 2024
@rcaudy
Copy link
Member

rcaudy commented Jan 12, 2024

Looks like this may be a poor choice, unless we check attributes and verify that we have an append-only or flat table.

            final WritableRowRedirection rowRedirection =
                    new LongColumnSourceWritableRowRedirection(new LongSparseArraySource());

We should probably use a io.deephaven.engine.table.impl.util.WritableRowRedirectionLockFree for general workloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barrage bug Something isn't working core Core development tasks java-client query engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants