Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarrageStreamGeneratorImpl#getSubView Should Be Bifurcated into FullSubscriptionView and ViewportSubscriptionView #6383

Open
nbauernfeind opened this issue Nov 15, 2024 · 0 comments
Assignees
Milestone

Comments

@nbauernfeind
Copy link
Member

nbauernfeind commented Nov 15, 2024

While reviewing #6347 it became clear how much simpler it would be to review this particular piece of code if the interface was split into at least two view-like implementations, possibly three.

  • Full Subscriptions should have their own entry point.
  • Viewport Subscriptions should have their own entry point.
  • Possibly Growing Viewports should have their own entry point.

We also need a design document, deephaven.io level documentation, or perhaps just very good javadoc in this file, describing the three strategies and how one can expect the RecordBatch to be structured and populated.

@nbauernfeind nbauernfeind self-assigned this Nov 15, 2024
@rcaudy rcaudy added this to the 0.38.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants