Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal error when last cell is empty and last line is not terminated #162

Closed
kosak opened this issue Dec 2, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@kosak
Copy link
Contributor

kosak commented Dec 2, 2023

Given input like this

      final String input = "A,B\n" +
                "apple,banana\n" +
                "cherry,";

Column A should read as "apple", "cherry"
and column B should read as "banana", ""
(furthermore the empty string will probably be tranlsated to null, depending on user settings)

but the lack of newline at the end of the final row makes the library throw "Logic error: uncaught short last row"

@kosak kosak added the bug Something isn't working label Dec 2, 2023
@kosak kosak self-assigned this Dec 2, 2023
@kosak kosak changed the title Fails to parse when last cell is empty and last line is not terminated Internal error when last cell is empty and last line is not terminated Dec 2, 2023
kosak added a commit to kosak/deephaven-csv that referenced this issue Dec 2, 2023
kosak added a commit to kosak/deephaven-csv that referenced this issue Dec 2, 2023
kosak added a commit to kosak/deephaven-csv that referenced this issue Dec 2, 2023
kosak added a commit that referenced this issue Dec 5, 2023
@kosak
Copy link
Contributor Author

kosak commented Dec 8, 2023

Fixed in #163

@kosak kosak closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant