Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started > Other installation patterns > Build from source #37

Closed
margaretkennedy opened this issue Jan 8, 2024 · 5 comments
Closed
Assignees
Labels
update An update to existing documentation

Comments

@margaretkennedy
Copy link
Collaborator

margaretkennedy commented Jan 8, 2024

Edit: https://deephaven.io/core/docs/how-to-guides/launch-build/

PR https://github.com/deephaven/deephaven.io/pull/3862

reviewer = @niloc132

@margaretkennedy margaretkennedy added the update An update to existing documentation label Jan 8, 2024
@margaretkennedy margaretkennedy added this to the February 2024 (EOM) milestone Jan 8, 2024
@margaretkennedy margaretkennedy changed the title https://deephaven.io/core/docs/how-to-guides/install-and-run-natively/ Getting Started > Other installation patterns > Build from source Jan 8, 2024
@stanbrub
Copy link

This part is wrong because printVersion produces a version with a different format than the python wheel.

pip install "py/server/build/wheel/deephaven_core-<version>-py3-none-any.whl[autocomplete]"
Where <version> is replaced with the Gradle version in use:
./gradlew -q printVersion

So we could:

  • Explain how to translate the version to the right format
  • Provide a find command to get the correct wheel file (there should be only one, right?)

@devinrsmith
Copy link
Member

I've been preferring to use --find-links, as it doesn't require us to know the physical wheel name:

pip install --find-links py/server/build/wheel "deephaven-core[autocomplete]==<version>"

For example, during development of 0.34.0:

pip install --find-links py/server/build/wheel "deephaven-core[autocomplete]==0.34.0+snapshot"

@devinrsmith
Copy link
Member

I bet this could even be done without any version:

pip install --find-links py/server/build/wheel "deephaven-core[autocomplete]"

@stanbrub
Copy link

This appears to work. Thanks.

pip install --find-links py/server/build/wheel "deephaven-core[autocomplete]"

@stanbrub
Copy link

Is there any reason we need to keep this the Note If you prefer not to use autocomplete, remove [autocomplete] from the wheel installation. ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update An update to existing documentation
Projects
None yet
Development

No branches or pull requests

3 participants