From 46ab2e0cb8eff067d091b53d70ed02176031bf4b Mon Sep 17 00:00:00 2001
From: Steven Wu <wusteven815@gmail.com>
Date: Wed, 13 Mar 2024 11:02:16 -0400
Subject: [PATCH] ci: remove docker down

---
 .github/workflows/e2e.yml | 4 ++++
 tools/run_docker.sh       | 7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 74bfd73ef..37ebc1581 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -31,6 +31,10 @@ jobs:
           path: playwright-report/
           retention-days: 90
 
+      - name: Dump server logs
+        if: failure()
+        run: docker logs deephaven-plugins > /tmp/server-log.txt
+  
       - name: Upload server logs
         if: failure()
         uses: actions/upload-artifact@v4
diff --git a/tools/run_docker.sh b/tools/run_docker.sh
index 2fe74ceee..d2f9ab056 100755
--- a/tools/run_docker.sh
+++ b/tools/run_docker.sh
@@ -6,12 +6,13 @@ pushd "$(dirname "$0")"
 # Start the containers
 if [[ -z "${CI}" ]]; then
   docker compose run --service-ports --rm --build "$@"
+  exit_code=$?
+  docker compose down
 else
   docker compose run --service-ports --rm --build -e CI=true "$@"
+  exit_code=$?
+  docker compose stop deephaven-plugins
 fi
-exit_code=$?
-docker logs deephaven-plugins > /tmp/server-log.txt 2>&1
-docker compose down
 
 # Reset pwd
 popd