From 4c0bc7b17618f88b06465ad8d837520d97e48987 Mon Sep 17 00:00:00 2001 From: Mike Bender Date: Thu, 29 Feb 2024 15:30:00 -0500 Subject: [PATCH] Fix failing unit test - Also added crash logs to gitignore --- .gitignore | 4 ++++ plugins/ui/test/deephaven/ui/test_hooks.py | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f431fa514..e3c012457 100644 --- a/.gitignore +++ b/.gitignore @@ -24,3 +24,7 @@ docker-compose.override.yml # Ignore temporary files created during a release releases/ + +# virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml +hs_err_pid* +replay_pid* \ No newline at end of file diff --git a/plugins/ui/test/deephaven/ui/test_hooks.py b/plugins/ui/test/deephaven/ui/test_hooks.py index 4ee6468bd..1a9fcfb8c 100644 --- a/plugins/ui/test/deephaven/ui/test_hooks.py +++ b/plugins/ui/test/deephaven/ui/test_hooks.py @@ -151,7 +151,7 @@ def listener(update: TableUpdate, is_replay: bool) -> None: event.set() def _test_table_listener(replayed_table_val=table, listener_val=listener): - use_table_listener(replayed_table_val, listener_val, set()) + use_table_listener(replayed_table_val, listener_val, []) render_hook(_test_table_listener) @@ -171,7 +171,7 @@ def listener(update: TableUpdate, is_replay: bool) -> None: event.set() def _test_table_listener(replay_table=table, listener_val=listener): - use_table_listener(replay_table, listener_val, do_replay=True) + use_table_listener(replay_table, listener_val, [], do_replay=True) render_hook(_test_table_listener)