From c359227bf53e52d147cfd8921b0e42e4fdc55db3 Mon Sep 17 00:00:00 2001 From: Matthew Runyon Date: Wed, 2 Oct 2024 00:59:44 -0500 Subject: [PATCH] Change to height and width 100% to fix e2e --- plugins/ui/src/js/src/styles.scss | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/plugins/ui/src/js/src/styles.scss b/plugins/ui/src/js/src/styles.scss index 5e9158130..82fe055a2 100644 --- a/plugins/ui/src/js/src/styles.scss +++ b/plugins/ui/src/js/src/styles.scss @@ -8,10 +8,17 @@ } .ui-table-container { - height: -webkit-fill-available; - height: -moz-available; - width: -webkit-fill-available; - width: -moz-available; + // If all browsers properly supported 'stretch' for height and width + // we could swap to that, but right now only Chrome properly implements it. + // Stretch is prefixed as -webkit-fill-available for Chrome and Webkit + // and -moz-available for Firefox. + // Firefox and Webkit only seem to apply properly stretch to width, not height. + // The benefit to swapping width/height to stretch is that a user + // specifying margin on a table would basically be treated as padding. + // This would create a better experience so tables with margin don't overflow the panel + // like they do with 100% width/height. + height: 100%; + width: 100%; position: relative; }