Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui.divider #1047

Merged
merged 14 commits into from
Jan 17, 2025
Merged

feat: ui.divider #1047

merged 14 commits into from
Jan 17, 2025

Conversation

AkshatJawne
Copy link
Contributor

@AkshatJawne AkshatJawne commented Nov 27, 2024

Closes #1038 and Closes #877

plugins/ui/docs/components/divider.md Outdated Show resolved Hide resolved
plugins/ui/src/deephaven/ui/components/divider.py Outdated Show resolved Hide resolved
tests/app.d/ui_render_all.py Outdated Show resolved Hide resolved
@AkshatJawne AkshatJawne requested a review from mofojed November 29, 2024 18:04
mofojed
mofojed previously approved these changes Nov 29, 2024
@dsmmcken
Copy link
Contributor

make docs is failing

margaretkennedy
margaretkennedy previously approved these changes Dec 2, 2024
AkshatJawne and others added 7 commits December 2, 2024 10:25
# Conflicts:
#	tests/ui.spec.ts-snapshots/UI-all-components-render-1-1-chromium-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-1-1-firefox-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-1-1-webkit-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-chromium-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-firefox-linux.png
#	tests/ui.spec.ts-snapshots/UI-all-components-render-2-1-webkit-linux.png
@ericlln ericlln requested a review from mofojed January 16, 2025 17:34
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for picking this up!

@ericlln ericlln merged commit 0a1b861 into deephaven:main Jan 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.divider docs: ui.divider
5 participants