-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line numbers in errors are not useful #9
Comments
Oddly when I run this script, I get the same error with different line numbers. Running selected line 10 I'm not sure how to get the That said, even if the line number is positive, there are 2 issues I see here:
I do actually see this same behavior in code studio, so I think this is something that we should create a ticket for there and address there as well. The line number issue is likely something we can address only there and get it for free in the extension. The filename may be more nuanced since vscode file could be something outside of what code studio is aware of and would need special handling. |
@chipkent there's a possibility the |
I was able to reproduce the |
I talked to @mofojed about this one. It seems the We also discussed the lack of filename in the error message. This is due to the server being unaware of files at all since we are only passing the file content or selection. The output message |
Actually, looking at that, there is a |
I'm reopening this. The problem is real. import sys; print(sys.version)
from deephaven import empty_table, time_table
from deephaven.plot import Figure
t1 = empty_table(10).update(["X = i", "Y = 10 * i"])
t2 = time_table("PT1s").update(["X = i%10", "Y = 10 * i"])
t3 = t1.natural_join(t2.last_by("X"), on="X", joins="YY=Y")
p1 = Figure().plot_xy("Plot 1", t1, x="X", y="Y").show()
p2 = Figure().plot_xy(t2, "X", "Y").show()
# p1 = Figure().plot_xy("Plot 1", t1, x="X", y="Y").show()
# p2 = Figure().plot_xy("Plot 2", t2, x="X", y="Y").show()
print("DH Rules")
print("DH Sucks")
# import mymod
Note here that the problem is in the creation of |
Note that the above has |
Fixed by jpy-consortium/jpy#158 |
UPDATE 08/12:
This PR may fix the root cause in jpy jpy-consortium/jpy/pull/158
UPDATE 07/16: I think #39 Expose python code errors as diagnostics should address the user experience challenge on this one. It won't help with the
-1
line numbers which seems likely to be a Python runtime bug (see python/cpython#101400 for an example).I run this code with a known error on line 11.
Here is the error -- no mention of line 11 or even the file name:
The text was updated successfully, but these errors were encountered: