-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix e2e tests for builds on v0.78 #2315
Conversation
mofojed
commented
Dec 13, 2024
•
edited
Loading
edited
- The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI
- Just pin the e2e tests to an older build of core
- Disabled webkit - the tests were flakey, and updating them would require updating playwright which would require updating all snapshots and reverifying them
- The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI - Just pin the e2e tests to an older build of core
Not sure why this is failing e2e. From the logs:
Which seems to indicate that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.78 #2315 +/- ##
==============================================
Coverage 46.41% 46.41%
==============================================
Files 676 676
Lines 38875 38875
Branches 9841 9816 -25
==============================================
Hits 18043 18043
Misses 20779 20779
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Not going to wrestle with it anymore