Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix e2e tests for builds on v0.78 #2315

Merged
merged 14 commits into from
Dec 26, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 13, 2024

  • The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI
  • Just pin the e2e tests to an older build of core
  • Disabled webkit - the tests were flakey, and updating them would require updating playwright which would require updating all snapshots and reverifying them

- The edge version of deephaven-core installs the latest version of deephaven.ui, which is not compatible with this old version of the UI
- Just pin the e2e tests to an older build of core
@mofojed mofojed requested a review from vbabich December 13, 2024 21:08
@mofojed mofojed self-assigned this Dec 13, 2024
vbabich
vbabich previously approved these changes Dec 13, 2024
@mofojed
Copy link
Member Author

mofojed commented Dec 16, 2024

Not sure why this is failing e2e. From the logs:

[WebServer] @deephaven/code-studio: failed to load config from /home/runner/work/web-client-ui/web-client-ui/packages/code-studio/vite.config.ts
[WebServer] @deephaven/code-studio: error when starting preview server:
[WebServer] @deephaven/code-studio: TypeError [ERR_INVALID_ARG_TYPE]: The "paths[1]" argument must be of type string. Received undefined

Which seems to indicate that VITE_BUILD_PATH is undefined. Looking at the web-build logs attached to the failed e2e tests, it looks like the .env file that would set this does not exist, or any other "hidden" file. Unsure why those files are not copied over.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.41%. Comparing base (882980d) to head (3866213).

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0.78    #2315   +/-   ##
==============================================
  Coverage          46.41%   46.41%           
==============================================
  Files                676      676           
  Lines              38875    38875           
  Branches            9841     9816   -25     
==============================================
  Hits               18043    18043           
  Misses             20779    20779           
  Partials              53       53           
Flag Coverage Δ
unit 46.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed requested a review from vbabich December 26, 2024 18:26
@mofojed mofojed merged commit 40ef6f7 into deephaven:release/v0.78 Dec 26, 2024
9 checks passed
@mofojed mofojed deleted the fix-e2e-vplus branch December 26, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants