Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export Spectrum Menu and SubmenuTrigger #2322

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

dgodinez-dh
Copy link
Contributor

Need to export these to implement menu in deephave.ui
https://deephaven.atlassian.net/browse/DH-18089

@dgodinez-dh dgodinez-dh requested a review from a team December 30, 2024 16:46
@dgodinez-dh dgodinez-dh self-assigned this Dec 30, 2024
@dgodinez-dh dgodinez-dh requested review from bmingles and removed request for a team December 30, 2024 16:46
@dgodinez-dh dgodinez-dh changed the title DH-18089: Export Spectrum Menu and SubmenuTrigger feat: Export Spectrum Menu and SubmenuTrigger Dec 30, 2024
@dgodinez-dh dgodinez-dh requested review from mofojed and removed request for bmingles December 30, 2024 16:48
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.71%. Comparing base (9d6719a) to head (1d5435b).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2322    +/-   ##
========================================
  Coverage   46.71%   46.71%            
========================================
  Files         704      704            
  Lines       39013    39013            
  Branches     9932     9747   -185     
========================================
  Hits        18224    18224            
  Misses      20778    20778            
  Partials       11       11            
Flag Coverage Δ
unit 46.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgodinez-dh dgodinez-dh merged commit d4eab8a into deephaven:main Dec 30, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants