fix: Update Spectrum Theme for Missing ContextualHelpTrigger Icon #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
=======================================
Coverage 46.71% 46.71%
=======================================
Files 704 704
Lines 39031 39031
Branches 9752 9752
=======================================
Hits 18234 18234
Misses 20786 20786
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
changed the title
dsmmcken
previously approved these changes
Jan 10, 2025
dsmmcken
reviewed
Jan 10, 2025
| @@ -9,6 +9,12 @@ label[class*='spectrum-'] { | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| [class*='spectrum-Menu-itemGrid'] svg, | |||
There was a problem hiding this comment.
you could consider linking this to PR that would allow this lines removal
dsmmcken
approved these changes
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 46.71% 46.70% -0.02%
==========================================
Files 704 704
Lines 39031 39044 +13
Branches 9752 9942 +190
==========================================
Hits 18234 18234
+ Misses 20786 20756 -30
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
ui.menuhttps://deephaven.atlassian.net/browse/DH-18089
The ContexualHelpTrigger icon does not display because incorrect box-sizing.