feat: DH-18086: gRPC transport implementation for nodejs backed by http2 #2339
+203
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
DH-18086-2_http2-grpc-transport
branch
from
eb3a171 to
c25f9cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
========================================
Coverage 46.70% 46.70%
========================================
Files 704 704
Lines 39044 39044
Branches 9757 9942 +185
========================================
Hits 18234 18234
+ Misses 20799 20756 -43
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
requested review from
a team and
vbabich
and removed request for
a team
vbabich
reviewed
Jan 14, 2025
| cancel(): void { | ||
| logger.debug('cancel'); | ||
| assertNotNull(this.request, 'request is required'); | ||
| this.request.close(); |
There was a problem hiding this comment.
Should we reset request to null here? Probably not needed, if request.write handles closed requests fine.
There was a problem hiding this comment.
Good question. @niloc132 do you have any thoughts on this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DH-18086: gRPC transport implementation for nodejs backed by http2
Note that this is not consumed anywhere in the web but will be used by the vscode extension and tested on
deephaven/vscode-deephaven#202